Skip to content

Commit

Permalink
Keep track of TCK coverage.
Browse files Browse the repository at this point in the history
Run the non TCK test to ensure there is always at least one test.

[JSR 303 TCK Result] WARNING only 191 of 258 (74.03%) TCK Tests Covered.
[JSR 303 TCK Result] 151 of 257 (58.75%) Pass with 32 Failures and 7 Errors.

Review at http://gwt-code-reviews.appspot.com/1575803

Review by: [email protected]

git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10707 8db76d5a-ed1c-0410-87a9-c151d255dfc7
  • Loading branch information
[email protected] committed Oct 17, 2011
1 parent b8ee117 commit 6250edd
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 3 deletions.
11 changes: 10 additions & 1 deletion user/style/html/junit-noframes.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@
<xsl:variable name="timeCount" select="sum(testsuite/@time)"/>
<xsl:variable name="passedCount" select="($testExecutedCount - $failureCount - $errorCount)"/>
<xsl:variable name="successRate" select="($passedCount) div $testCount"/>
<xsl:variable name="coveredCount" select="$testExecutedCount + $markedNotSupported + $markedTestNotCompatible"/>
<h3>
<xsl:value-of select="$passedCount" /> <xsl:text> of </xsl:text>
<xsl:value-of select="$testCount"/> <xsl:text> (</xsl:text>
Expand All @@ -279,10 +280,18 @@
</h3>

<xsl:if test="($failureCount + $errorCount) != ($markedFailing)">
<p style="color:red"><strong>WARINING</strong> expected Failures + Errors to match the
<p style="color:red"><strong>WARNING</strong> expected Failures + Errors to match the
<xsl:value-of select="$markedFailing" />
test marked @Failing</p>
</xsl:if>
<xsl:if test="($rawTestCount) != ($coveredCount)">
<p style="color:red"><strong>WARNING</strong> only
<xsl:value-of select="$coveredCount" /> of
<xsl:value-of select="$rawTestCount"/> (<xsl:call-template name="display-percent">
<xsl:with-param name="value" select="$coveredCount div $rawTestCount"/>
</xsl:call-template>) TCK Tests Covered.</p>
</xsl:if>

<table class="details" border="0" cellpadding="5" cellspacing="2" width="95%">
<tr valign="top">
<th>Tests</th>
Expand Down
17 changes: 15 additions & 2 deletions user/style/text/junit-noframes.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,33 @@
<xsl:variable name="timeCount" select="sum(testsuite/@time)"/>
<xsl:variable name="passedCount" select="($testExecutedCount - $failureCount - $errorCount)"/>
<xsl:variable name="successRate" select="($passedCount) div $testCount"/>
<xsl:variable name="coveredCount" select="$testExecutedCount + $markedNotSupported + $markedTestNotCompatible"/>
<xsl:if test="($failureCount + $errorCount) != ($markedFailing)">
<xsl:text>WARINING expected Failures + Errors to match the </xsl:text>
<xsl:text>WARNING expected Failures + Errors to match the </xsl:text>
<xsl:value-of select="$markedFailing" />
<xsl:text> test marked @Failing
</xsl:text>
</xsl:if>
<xsl:if test="($rawTestCount) != ($coveredCount)">
<xsl:text>WARNING only </xsl:text>
<xsl:value-of select="$coveredCount" /> <xsl:text> of </xsl:text>
<xsl:value-of select="$rawTestCount"/> <xsl:text> (</xsl:text>
<xsl:call-template name="display-percent">
<xsl:with-param name="value" select="$coveredCount div $rawTestCount"/>
</xsl:call-template>
<xsl:text>) TCK Tests Covered.
</xsl:text>
</xsl:if>
<xsl:value-of select="$passedCount" /> <xsl:text> of </xsl:text>
<xsl:value-of select="$testCount"/> <xsl:text> (</xsl:text>
<xsl:call-template name="display-percent">
<xsl:with-param name="value" select="$successRate"/>
</xsl:call-template>
<xsl:text>) Pass with </xsl:text>
<xsl:value-of select="$failureCount"/> <xsl:text> Failures and </xsl:text>
<xsl:value-of select="$errorCount" /> <xsl:text> Errors.</xsl:text>
<xsl:value-of select="$errorCount" /> <xsl:text> Errors.
</xsl:text>

</xsl:template>

<xsl:template name="display-percent">
Expand Down

0 comments on commit 6250edd

Please sign in to comment.