Trap window.onerror by default.

Changes gwt.uncaughtexceptionhandler.windowonerror to REPORT_IF_NO_HANDLER. This is a good default for most GWT applications. see: https://gwt-review.googlesource.com/c/gwt/+/18540 This re-rolls commit e1f1eb0 Change-Id: I4f2e9e923136356b48a306f36f4c05ff9c21fe92
Shasthojoy · Oct 12, 2017 · d9fe189 · d9fe189
1 parent beecee6
commit d9fe189
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/user/src/com/google/gwt/core/Core.gwt.xml b/user/src/com/google/gwt/core/Core.gwt.xml
@@ -92,7 +92,7 @@
      - Do not trap anything (legacy behavior) (IGNORE)
   -->
   <define-property name="gwt.uncaughtexceptionhandler.windowonerror" values="IGNORE, REPORT, REPORT_IF_NO_HANDLER" />
-  <set-property name="gwt.uncaughtexceptionhandler.windowonerror" value="IGNORE"/>
+  <set-property name="gwt.uncaughtexceptionhandler.windowonerror" value="REPORT_IF_NO_HANDLER"/>
 
   <!-- To support legacy logging flags -->
   <inherits name="com.google.gwt.logging.LogImpl"/>

diff --git a/user/test/com/google/gwt/core/WindowOnError.gwt.xml b/user/test/com/google/gwt/core/WindowOnError.gwt.xml
diff --git a/user/test/com/google/gwt/core/client/WindowOnErrorTest.java b/user/test/com/google/gwt/core/client/WindowOnErrorTest.java
@@ -27,7 +27,7 @@ public class WindowOnErrorTest extends GWTTestCase {
 
   @Override
   public String getModuleName() {
-    return "com.google.gwt.core.WindowOnError";
+    return "com.google.gwt.core.Core";
   }
 
   @Override