Handle unexpected HTTP responses #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaflanagan
force-pushed
the
error-handling
branch
from
39cdbc2 to
f1f6d96
Compare
Pull Request Test Coverage Report for Build 9717752223Details
💛 - Coveralls |
If the response cannot be parsed as JSON, we will throw a ShipEngineException, and include the actual response.
joshuaflanagan
force-pushed
the
error-handling
branch
from
f1f6d96 to
97f70e7
Compare
Pull Request Test Coverage Report for Build 9718240694Details
💛 - Coveralls |
If error details weren't found, the user would get back an empty deserialized object.
Capture the request ID from the response headers, in case the body does not include it.
Pull Request Test Coverage Report for Build 9718822717Details
💛 - Coveralls |
jpill
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will better handle the situation where the HTTP response body cannot be parsed as JSON.
Instead of throwing a
JsonException, we will throw aShipEngineExceptioncontaining theHttpResponseMessage. This will give the caller a chance to handle the response in their own way.We will also try to include a request ID on all
ShipeEngineExceptionnow - by pulling from the response header in cases where we don't get a ShipEngine Error JSON response.