Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some data issues in parallel/parallel multiple answers #423

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

vandyxiaowei
Copy link
Contributor

some parameters have default value, so it should be acceptable if the model doesn't predict the parameter. add "" in the possible answers for those cases.

Please take a look. Thanks!

Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vandyxiaowei,

Thanks for contributing!

One minor request: Could we exclude the linting changes from this PR? This would help better highlight the changes to the possible answers. Right now the "Files changed" section indicates over 200 additions and deletions, which are predominantly whitespace alterations. These do not impact the evaluation pipeline's correctness but could obscure the actual modifications to possible answers when other people look at this PR.

Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vandyxiaowei,

I want to sincerely apologize for the delay in reviewing your pull request. The past few months have been particularly busy, and unfortunately, I let this slip through the cracks. Really sorry about the long wait!

I’ve now had a chance to review your changes, and everything looks great. Thank you very much for your contribution!

For other people looking at this PR: Apart from the whitespace adjustments (which are quite a lot, but don't affect evaluation correctness at all), this PR contains 37 possible_answer entry fixes. All of them are due to the missing "" for the optional parameter. Here's a breakdown of the changes:

  • parallel function category: 13 entries affected.
    • Indices: 3, 73, 103, 105, 113, 115, 116, 127, 129, 146, 189, 195, 200
  • parallel_multiple function category: 24 entries affected
    • Indices: 29, 61, 64, 67, 72, 75, 76, 85, 89, 94, 95, 97, 100, 101, 117, 119, 126, 129, 132, 156, 157, 184, 185, 195

We will update the leaderboard soon to reflect this change.

@ShishirPatil ShishirPatil merged commit feb1a2a into ShishirPatil:main Jul 7, 2024
ShishirPatil pushed a commit that referenced this pull request Jul 8, 2024
…for AST Parallel and Parallel_Multiple Category) (#507)

This PR updates the leaderboard to reflect the changes in score due to
#423 and #503. Only the score for AST Parallel and AST Parallel_Multiple
Categories are affected.

We want to thank @vandyxiaowei for helping fix the possible answers.
devanshamin pushed a commit to devanshamin/gorilla that referenced this pull request Jul 9, 2024
…til#423)

some parameters have default value, so it should be acceptable if the
model doesn't predict the parameter. add "" in the possible answers for
those cases.

Please take a look. Thanks!

Co-authored-by: Xiaowei Li <[email protected]>
Co-authored-by: Huanzhi (Hans) Mao <[email protected]>
aw632 pushed a commit to vinaybagade/gorilla that referenced this pull request Aug 22, 2024
…til#423)

some parameters have default value, so it should be acceptable if the
model doesn't predict the parameter. add "" in the possible answers for
those cases.

Please take a look. Thanks!

Co-authored-by: Xiaowei Li <[email protected]>
Co-authored-by: Huanzhi (Hans) Mao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants