[BFCL] Overhaul apply_function_credential_config.py for Enhanced Usability #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieJCJ
approved these changes
Jul 8, 2024
berkeley-function-call-leaderboard/apply_function_credential_config.py
Outdated
Show resolved
Hide resolved
berkeley-function-call-leaderboard/apply_function_credential_config.py
Outdated
Show resolved
Hide resolved
ShishirPatil
approved these changes
Jul 17, 2024
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
…ility (ShishirPatil#508) Currently, the `apply_function_credential_config.py` requires the user to manually provide the input file path and it only takes one single file path at a time, which is very cumbersome and user-unfriendly, considering that the user must do this 14 times for each of the test dataset files. This PR refactors the script to improve its usability: 1. The script no longer requires an input file path. It automatically searches for datasets in the default `./data/` directory. 2. The script now can process all files within the specified location (when `--input-path` is set to a directory path), thereby supporting bulk operations. 3. Single file path input is still supported. This PR partially addresses ShishirPatil#501 and ShishirPatil#502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
apply_function_credential_config.pyrequires the user to manually provide the input file path and it only takes one single file path at a time, which is very cumbersome and user-unfriendly, considering that the user must do this 14 times for each of the test dataset files.This PR refactors the script to improve its usability:
./data/directory.--input-pathis set to a directory path), thereby supporting bulk operations.This PR partially addresses #501 and #502.