Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BFCL] Hot Fix to Remove Extra Parameters for NoAPIKeyError #636

Merged
merged 1 commit into from
Sep 14, 2024
Merged

[BFCL] Hot Fix to Remove Extra Parameters for NoAPIKeyError #636

merged 1 commit into from
Sep 14, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

This PR won't impact the leaderboard score.

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Sep 12, 2024
@HuanzhiMao HuanzhiMao marked this pull request as ready for review September 12, 2024 23:13
ShishirPatil
ShishirPatil reviewed Sep 12, 2024
View reviewed changes
Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this? Isn't it ok for users to not include all the keys. They may choose to provide only a subset of keys?

@HuanzhiMao
Copy link
Collaborator Author

Why are we doing this? Isn't it ok for users to not include all the keys. They may choose to provide only a subset of keys?

All 4 executable API keys are required for the exec test category. If only a subset is provided, the evaluation result will still be unreliable.

@ShishirPatil ShishirPatil merged commit 12f641c into ShishirPatil:main Sep 14, 2024
@HuanzhiMao HuanzhiMao deleted the exception-patch branch September 23, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieJCJ CharlieJCJ CharlieJCJ approved these changes

@ShishirPatil ShishirPatil ShishirPatil approved these changes

Assignees
No one assigned
Labels
BFCL-General General BFCL Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuanzhiMao @ShishirPatil @CharlieJCJ