Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Replace 'class' with '_class' to Avoid Function Calling Formatting Error #811

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

Fanjia-Yan
Copy link
Collaborator

@Fanjia-Yan Fanjia-Yan commented Dec 3, 2024

This pull request addresses an issue where using the reserved keyword class as a parameter name causes function calling errors. The parameter name class has been replaced with _class to avoid conflicts.

@Fanjia-Yan Fanjia-Yan added the BFCL-Dataset BFCL Dataset-Related Issue label Dec 3, 2024
@HuanzhiMao HuanzhiMao removed their assignment Dec 3, 2024
@HuanzhiMao HuanzhiMao changed the title Replace 'class' with '_class' to Avoid Function Calling Formatting Error [BFCL] Replace 'class' with '_class' to Avoid Function Calling Formatting Error Dec 3, 2024
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuanzhiMao HuanzhiMao merged commit 311b354 into ShishirPatil:main Dec 3, 2024
VishnuSuresh27 pushed a commit to VishnuSuresh27/gorilla that referenced this pull request Dec 6, 2024
…ting Error (ShishirPatil#811)

This pull request addresses an issue where using the reserved keyword
class as a parameter name causes function calling errors. The parameter
name `class` has been replaced with `_class` to avoid conflicts.

---------

Co-authored-by: Huanzhi (Hans) Mao <[email protected]>
HuanzhiMao added a commit that referenced this pull request Dec 7, 2024
This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #747 
2. #770 
3. #768 
4. #750 
5. #763 
6. #772 
7. #777 
8. #778 
9. #786 
10. #787 
11. #697 
12. #718 
13. #755 
14. #796 
15. #789 
16. #804 
17. #808 
18. #809
19. #811 
20. #810 

Models were evaluated using checkpoint commit d7e52e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-Dataset BFCL Dataset-Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants