Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Change collection list paginate by count to match collection #445

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

jonathanmoore
Copy link
Contributor

During a theme review with the Shopify team having different paginate by counts for the collection and collection list views came up as an issue. Here are the steps to recreate the potential bug with mismatched pagination counts:

  • Create a collection with 25 or more products
  • The collection template will paginate over 3 pages
  • Go to the last page
  • Switch from collection to collection.list view
  • Now you will see "Sorry, there are no products in this collection" since the page does not exist with the higher list pagination count.

It was incredibly helpful having Timber as a guideline to work from for our first theme. Hopefully this small change will help someone else.

@cshold
Copy link
Contributor

cshold commented Jun 30, 2015

Hadn't even considered that to be a potential issue, but great catch. Thanks!

cshold added a commit that referenced this pull request Jun 30, 2015
Change collection list paginate by count to match collection
@cshold cshold merged commit a0d507f into Shopify:master Jun 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants