This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Fix structured data price rounding issue and usage warning #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rounding issue caused by usingdivided_by
Math filter.> Divides an output by a number. The output is rounded down to the nearest integer.i.e. 3499.95 was being rounded down to 3499See: https://help.shopify.com/themes/liquid/filters/math-filters#divided_byBringprice
implementation inline with usage guidelines. No longer produces warning in Google's Structured Data Testing Tool for values greater than 999.99 that use comma separator for readability.> Use '.' (Unicode 'FULL STOP' (U+002E)) rather than ',' to indicate a decimal point. Avoid using these symbols as a readability separator.See: http://schema.org/priceUpdated pull request based on solution in comments provided by @cshold