Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@shopify/checkout-sheet-kit #44

Merged
merged 4 commits into from
Jan 8, 2024
Merged

@shopify/checkout-sheet-kit #44

merged 4 commits into from
Jan 8, 2024

Conversation

markmur
Copy link
Contributor

@markmur markmur commented Dec 20, 2023

What are you trying to accomplish?

  • Update documentation
  • Rename module (react-native-shopify-checkout-kit@shopify/checkout-sheet-kit)
  • Update names of exports
    • ShopifyCheckoutKitShopifyCheckoutSheet
    • useShopifyCheckoutKituseShopifyCheckoutSheet
    • ShopifyCheckoutKitProviderShopifyCheckoutSheetProvider
  • Update name in package.json
  • Update exported modules for iOS
  • Update exported modules for Android
  • Update tests
  • Update all import references in the sample app
  • Update all module usage in the sample app

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README.

@markmur markmur self-assigned this Dec 20, 2023
@markmur markmur marked this pull request as ready for review December 20, 2023 15:32
@markmur markmur requested a review from a team as a code owner December 20, 2023 15:32
@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.


This comment was added by the YarnLock::DupeWarning Caution Tape Bot rule.
View the source of this rule in Services DB

@cianbuckley cianbuckley self-requested a review January 8, 2024 11:13
Copy link

@cianbuckley cianbuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmur markmur merged commit afc9a90 into main Jan 8, 2024
@markmur markmur deleted the checkout-sheet-kit branch January 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants