Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow to set a success_debrief to debrief successful tasks #356

Merged
merged 1 commit into from
Nov 28, 2022
Merged

✨ Allow to set a success_debrief to debrief successful tasks #356

merged 1 commit into from
Nov 28, 2022

Conversation

marianosimone
Copy link
Contributor

This allows users to specify if they want some kind of debrief, even when the tasks succeed.

Closes #355

@marianosimone marianosimone requested a review from a team as a code owner November 27, 2022 18:52
lugray
lugray approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@lugray lugray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lugray lugray merged commit e320e15 into Shopify:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugray lugray lugray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow to debrief successful SpinGroups
2 participants
@marianosimone @lugray