Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react version mismatch [stable] #3813

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Apr 30, 2024

WHY are these changes introduced?

Fixes #3800
Fixes Shopify/hydrogen#2040

Fix a react version mismatch

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.01% 6930/9623
🟡 Branches 69.1% 3413/4939
🟡 Functions 71.19% 1851/2600
🟡 Lines 73.29% 6535/8917

Test suite run success

1653 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from d24a128

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.59.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.59.1";
\ No newline at end of file

@isaacroldan isaacroldan changed the title Fix react version mismatch Fix react version mismatch [stable] Apr 30, 2024
@isaacroldan isaacroldan merged commit c5a6adb into stable/3.59 Apr 30, 2024
@isaacroldan isaacroldan deleted the fix-react-mismatch branch April 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants