Unit-test for binary-column data corruption (#157) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2020 17:53
There seems to be a bug in the propagation of data from the binlog streamer to the binlog writer when using fixed-length BINARY columns. This commit adds an integration test that currently works only under very specific conditions, and prepares the code for the fix to the data propagation logic. Change-Id: Icef7ae558a38af4088280bb633f331711b835502
THIS PULL REQUEST IS NOT INTENDED TO BE MERGED, JUST FOR INTERNAL DISCUSSION. WE WILL NEED TO MODIFY THE UPSTREAM VERSION OF THE VENDOR'ED MODULE INSTEAD OF MODIFYING THE IMPORTED VERSION! This commit addresses a data corruption bug in the binlog streaming phase, where the binlog writer incorrectly propagates values in fixed-length BINARY columns that have trailing 0s in the original value. These trailing 0s are removed from the binlog by the SQL master and therefore do not show up in the WHERE clause for update/delete statements executed by the binlog writer. Change-Id: I7cd01c953ef2027e4f4fa71a62c5d7b30caa83c5
shuhaowu
reviewed
Mar 10, 2020
| @@ -167,6 +140,91 @@ func TestCopyDataWithNullInColumn(t *testing.T) { | |||
| testcase.Run() | |||
| } | |||
|
|
|||
| func TestCopyDataInFixedSizeBinaryColumn(t *testing.T) { | |||
There was a problem hiding this comment.
The golang integration tests are deprecated. Can you write the tests in the ruby integration test instead? Specifically it can go under https://github.com/Shopify/ghostferry/blob/master/test/integration/types_test.rb.
|
I assume this is superceded by #159. Reopen if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in the propagation of data from the binlog
streamer to the binlog writer when using fixed-length BINARY columns.
This commit adds an integration test that currently works only under
very specific conditions, and prepares the code for the fix to the data
propagation logic.