-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrogen-ui storefront API schema and types #1122
Conversation
Co-authored-by: Michelle Vinci <[email protected]>
Co-authored-by: Michelle Vinci <[email protected]>
Co-authored-by: Matt Seccafien <[email protected]>
Co-authored-by: Matt Seccafien <[email protected]>
We detected some changes in |
- [Add autocompletion for the Storefront API](#storefront-api-graphql-autocompletion) | ||
- [Add Typescript types for Storefront API objects](#typescript-types) | ||
|
||
## Storefront API GraphQL autocompletion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cartogram What we talked about this morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd like to ship an unstable version of this after merge and test it out.
Hydrogen-ui isn't publishing yet, but that's on my todo list this week. |
Closes #1025 (and checks off an item on my list) and adds very basic intro docs on how to implement these features.
Relies on #1115 to be merged first, since it builds on that PR. (Opened this PR against that PR so that this one doesn't look as big, I'll change the target after 1115 is merged)One thing I'm still thinking about is the best way to make the storefront TS types accessible to hydrogen; currently, I think our choices are
Other ideas?