Remove status setters, and use a new response.notFound()
method.
#1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1488
We originally replaced
HydrogenResponse.writeHead()
withset status(value()
in #1433. However, we can't reliably override thestatus
andstatusText
properties of theResponse
class we're extending, because the implementation on some hosting runtimes like Cloudflare explicitly forbids it.This PR adds a new
HydrogenResponse.notFound()
method which developers can use to declare a 404 when inside an server component.Additional context
I don't anticipate developers needing to set custom response codes inside server components, so I think the removal of a custom status setter is an acceptable tradeoff.
Note that it is still possible to return a completely custom
Response
from API functions, where a custom status can be provided in the initial options:Before submitting the PR, please make sure you do the following:
fixes #123
)yarn changeset add
if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning