Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate InMemoryCache to Vitest #1909

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

mrkldshv
Copy link
Contributor

Description

Part of #670. Migration of InMemoryCache tests to Vitest.

Additional context


Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@mrkldshv
Copy link
Contributor Author

One E2E test failed here, but we probably just need to rerun it.

@frehner
Copy link
Contributor

frehner commented Jul 27, 2022

Looks like they're all passing, so let's merge this!

@frehner frehner merged commit 63bf6c3 into Shopify:v1.x-2022-07 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants