Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Money to Vitest #1991

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

mrkldshv
Copy link
Contributor

Description

Part of Shopify/hydrogen#670

Additional context


Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

Copy link
Contributor

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thanks for this!

The windows CI failure appears to be unrelated to your PR; we're looking into why. I think for now we can probably just merge this despite the windows CI failure.

@frehner frehner merged commit c9bc8a3 into Shopify:v1.x-2022-07 Aug 16, 2022
@mrkldshv
Copy link
Contributor Author

@frehner Thanks for reviewing the PR!

@mrkldshv mrkldshv deleted the chore/money-vitest branch August 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants