chore: improve Stackblitz publishing flow #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blittle
reviewed
Nov 10, 2021
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "installDependencies": true, | |||
There was a problem hiding this comment.
Is this sufficient for the --legacy-peer-deps?
There was a problem hiding this comment.
I guess so! It has been up to this point. We will see.
blittle
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RE: #125
Right now, I have to manually update our Stackblitz template in my personal template at https://hydrogen.new whenever we ship a release. This does not scale.
This PR:
_gitignoreso it gets picked up properly by stackblitz and force pushes to thestackblitzbranchLOCAL_DEVto prefix thedev-serverscript in the root of the monorepoYou can test out this new flow: https://stackblitz.com/fork/github/shopify/hydrogen/tree/stackblitz/packages/dev
Additional context
The
gitignoreshenanigans are to work around an interesting NPM publish behavior which renames.gitignoreto.npmignorelolol npm/npm#1862Before submitting the PR, please make sure you do the following:
fixes #123)