Migrate ProductOptionsProvider to Vitest #2156
Conversation
| }); | ||
| expect( | ||
| screen.getByText(JSON.stringify(VARIANTS.nodes)) | ||
| ).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('provides setSelectedVariant callback', async () => { |
There was a problem hiding this comment.
Currently this test case is not passing because e.target.value on line 179 is null. Spend some time debugging it, but couldn't find the reason. Any guesses? @frehner
|
In general this PR is ready except that one failing test that's mentioned below. |
|
Oh sorry, I've already migrated this over here and renamed it in the process. Do you want to compare what I have to what you have and see if I missed something in my migration? For the most part, the migration to Vitest is done - we've moved nearly everything over to hydrogen-ui (except Cart stuff, which is a separate work stream) and will eventually deprecate most of the components in the hydrogen package. The ones that are left, which are specific to Hydrogen-the-framework (e.g. |
|
No worries! I've checked the existing test, and I think I can submit PR with a few minor changes (e.g. refactor |
That sounds great to me. 👍 And for this PR, you thinking to close it...? |
|
Yeah, I guess this PR is not needed since we already have this test migrated. I'll close this PR, and open another one with small refactor changes. |
Description
Part of Shopify/hydrogen#670.
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning