Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite and remix #2696

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Bump vite and remix #2696

merged 6 commits into from
Jan 9, 2025

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Jan 8, 2025

WHY are these changes introduced?

Bump vite and Remix versions

  • Remix is bump to 2.15.2
  • Vite is bump to 5.1.8 - Latest vite is 6.0.7 but Remix only supports vite up to 5.1.8
  • Bump tailwind from v4 alpha to v4 beta

WHAT is this pull request doing?

HOW to test your changes?

For Remix and vite:

  1. Wipe your node_modules folder and reinstall the packages
  2. Run npm install, npm run build, npm run typcheck and make sure nothing fails
  3. Run any template or examples and make sure they work

For tailwind beta:

In the /templates folder:

  1. Run npx shopify hydrogen init and go thru the steps to generate a project with tailwind

Make sure the steps are referencing tailwind beta and not alpha. Make sure the project generated can be run locally.

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

This comment has been minimized.

Copy link
Contributor

shopify bot commented Jan 8, 2025

Oxygen deployed a preview of your hl-update-vite-remix branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 8, 202510:55 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment January 8, 202510:55 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 8, 202510:55 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 8, 202510:55 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 8, 202510:55 PM

Learn more about Hydrogen's GitHub integration.

@blittle
Copy link
Contributor

blittle commented Jan 9, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🫰✨ Thanks @blittle! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20250109174352",
"@shopify/hydrogen": "0.0.0-snapshot-20250109174352",
"@shopify/mini-oxygen": "0.0.0-snapshot-20250109174352",
"@shopify/remix-oxygen": "0.0.0-snapshot-20250109174352"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version>
To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the snapshot release. LGTM!

@wizardlyhel wizardlyhel merged commit fdab06f into main Jan 9, 2025
12 checks passed
@wizardlyhel wizardlyhel deleted the hl-update-vite-remix branch January 9, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants