Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was trying to run our benchmarks, since I wanted to make sure recent refactors didn't cause a performance regression. However, it looks like they got broken because they were doing some monkey patching of the private
resolve_cache_miss
method that got removed in the refactor.Running
dev benchmark-cpu
resulted in this error in the outputSolution
I just removed these conflict benchmarks, since the only difference they have is that they cause the
cas
oradd
memcached operations to fail, but identity cache doesn't have any code conditional on whether or not these operations succeed. As such, it was only really benchmarking dependencies of identity cache.