Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CAS for Dalli adapter #469

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fixing CAS for Dalli adapter #469

merged 2 commits into from
Jan 8, 2021

Conversation

glebglazov
Copy link
Contributor

When setting up test suite with values from docs (namely TTL option of Dalli client), fetch_multi method stops populating cache because params ordering that Dalli client expects is different from ordering that is used when calling replace_cas method:

@data.replace_cas(key, payload, options[:expires_in].to_i, cas_id, options)

https://github.com/petergoldstein/dalli/blob/e9afa45c5f8a134c4a7ca853530eb0ff8aeb3e01/lib/dalli/client.rb#L295

@ghost ghost added cla-needed and removed cla-needed labels Oct 2, 2020
@dylanahsmith dylanahsmith merged commit 423aa50 into Shopify:master Jan 8, 2021
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems January 8, 2021 19:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants