Support deferred expiration of records and attributes for one-to-many associations #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice looking pretty good so far... Why did you need to add |
Stivaros
reviewed
Oct 7, 2024
kirs
approved these changes
Oct 9, 2024
drinkbeer
force-pushed
the
jchen/deferred_expiration
branch
from
80d2148 to
7595790
Compare
drinkbeer
commented
Oct 9, 2024
drinkbeer
commented
Oct 9, 2024
Comment on lines
-50
to
-53
| if Thread.current[:idc_deferred_parent_expiration] | ||
| Thread.current[:idc_parent_records_for_cache_expiry] << parent | ||
| next parent | ||
| end |
There was a problem hiding this comment.
The parent.expire_primary_index underlying calls the primary_index.expire, so we have an if block in the primary_index.expire, we don't need separate Set here. Just make the parent and associated records in one Set, and call write_multi to the keys. It will make the code simpler and easier to understand.
grcooper
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_multi/write_multi) instead of expire each record in a loopidentity_cache_testin Mysql, achieved it by adding a Rake task