Fix thread throttler #stride API #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7madM
approved these changes
Jun 25, 2022
lib/lhm/throttler/threads_running.rb
Outdated
| DEFAULT_INITIAL_TIMEOUT = 0.1 | ||
| DEFAULT_HEALTHY_RANGE = (0..50) | ||
|
|
||
| attr_accessor :timeout_seconds, :healthy_range, :connection | ||
| attr_accessor :stride |
There was a problem hiding this comment.
Nit: would be cleaner to append :stride to the existing attr_accessor definition
kucaahbe
force-pushed
the
fix/thread-throtter-2
branch
from
1022962 to
23d8b6b
Compare
coding-chimp
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lhm::Throttler::ThreadsRunningwas missing the#stridemethod, which this PR fixes.Tests and more usage examples were added as well.