Avoid using the instant algorithm #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coding-chimp
force-pushed
the
bb/avoid-instant-algorithm
branch
from
a67b88b to
df3988b
Compare
mtaner
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 8 defaults to using the INSTANT algorithm for operations that support it. This change aims to avoid that.
We suspect we've run into a bug around using the INSTANT algorithm on empty tables. While this is still getting verified, using the algorithm is also entirely unnecessary for LHM. We're applying the changes to empty tables, which will always be quick. There's also a limit on how often you can instant changes to a table until it has to be rebuilt. Since you might be using LHM to rebuild the table, it makes sense not to use up the limit while doing it.