Add option to force tables to use default engine #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coding-chimp
force-pushed
the
bb/ignore-engine
branch
5 times, most recently
from
1e397a5 to
88f8c9a
Compare
coding-chimp
force-pushed
the
bb/ignore-engine
branch
from
88f8c9a to
11ceac0
Compare
coding-chimp
force-pushed
the
bb/ignore-engine
branch
from
11ceac0 to
4a69741
Compare
|
PR Looks good. The test covers the case we are exploring. Will be setting the |
Yes, that's the plan. I think not changing the engine with a schema migration is correct for most use cases. We have a special use case, so I'm adding this as an option and will enable it via our tooling. |
akshaysuryawanshi
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
force_default_engineoption. When enabled LHM will create the shadow table without copying the engine of the original table, meaning the migration will change the table to the default engine.