Fix lookup on variable with literal name #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#60 introduced a subtle regression for doing a lookup on a variable with a name that matches a literal.
For example,
would result in the following error after that pull request was introduced
but we would get the strict parse error on the commit before that PR was merged or when just using the liquid gem.
This quirk comes from the
LITERALS.key?(markup)
check being used to detect if the markup is for a literal. If that literal name is followed by an object lookup (e.g..svg
) then it is handled by VariableLookup which will treat the literal name (e.g.blank
) as the variable name.Solution
Lookahead to make sure the identifier isn't followed by a
.
or[
token before treating it as a literal.