Skip to content

Commit

Permalink
Merge pull request #938 from Shopify/remove-warnings-on-CI-failures-w…
Browse files Browse the repository at this point in the history
…ithout-a-screenshot

CI improvements
etiennebarrie authored Dec 20, 2023
2 parents 280bf6d + 5ce5e59 commit 246b204
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ Before engaging with this community, please read and understand our
## Setting up development environment

* The gem follows standard Rails practices:
* `bundle install` to install dependencies
* `bin/setup` to install dependencies
* `bin/rails server` to start the server
* `bin/rails test` to run tests
* `bin/rails test:system` to run system tests
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ jobs:
build:
runs-on: ubuntu-latest
name: Ruby ${{ matrix.ruby }} / ${{ matrix.gemfile }} / ${{ matrix.database }}
timeout-minutes: 5
strategy:
fail-fast: false
matrix:
@@ -50,5 +51,6 @@ jobs:
uses: actions/upload-artifact@v4
if: failure()
with:
name: screenshots
name: screenshots-${{ strategy.job-index }}
path: test/dummy/tmp/screenshots
if-no-files-found: ignore
6 changes: 6 additions & 0 deletions bin/setup
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/sh

set -ex

bundle install
bin/rails db:setup

0 comments on commit 246b204

Please sign in to comment.