Don't set ended_at when pausing stuck runs (#929)

Shopify · Dec 8, 2023 · 3542fb0 · 3542fb0
1 parent b08fbb8
commit 3542fb0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/app/models/maintenance_tasks/run.rb b/app/models/maintenance_tasks/run.rb
@@ -328,7 +328,6 @@ def cancel
     def pause
       if stuck?
         self.status = :paused
-        self.ended_at = Time.now
         persist_transition
       else
         pausing!

diff --git a/test/models/maintenance_tasks/run_test.rb b/test/models/maintenance_tasks/run_test.rb
@@ -649,7 +649,6 @@ class RunTest < ActiveSupport::TestCase
       travel Run::STUCK_TASK_TIMEOUT
       run.pause
       assert_predicate run, :paused?
-      assert_equal Time.now, run.ended_at
     end
 
     test "#persist_error rescues and retries ActiveRecord::StaleObjectError" do