Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding disable-gpu flag #1015

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

JoseWhite
Copy link
Contributor

Before disabling this flag on MacOs: Runtime was: 90+ seconds
After this change MacOs: Runtime down to 17.80s:

The disable gpu flag was added to application_system_test_case.rb application system test case

To application system test case
- Fixes slow system specs on MacOs
- Removing this could be handled in a later pr
Copy link
Contributor

@nvasilevski nvasilevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! It even speeds-up system tests on my remote linux machine from 17-19s to ~14s which makes me think we may see a faster CI in general. But indeed the greatest gains are observed on macos

Thanks!

@nvasilevski nvasilevski merged commit 71aec49 into Shopify:main May 8, 2024
21 checks passed
@etiennebarrie
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out slow system tests
3 participants