Add direct upload capability #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
force-pushed
the
seb-direct-upload
branch
3 times, most recently
from
7971d06 to
83087f5
Compare
lavoiesl
commented
May 28, 2024
Comment on lines
+88
to
+90
| assert_selector("input[type=file]") do |input| | ||
| assert_equal(input["data-direct-upload-url"], rails_direct_uploads_url) | ||
| end |
There was a problem hiding this comment.
Those tests are failing on Rails <= 7.0.
Not sure why, the usage is supposed to be the same: https://guides.rubyonrails.org/v6.1/active_storage_overview.html#usage
I could use some help 😅
lavoiesl
force-pushed
the
seb-assets-pipeline
branch
from
5ac5629 to
3082da6
Compare
lavoiesl
force-pushed
the
seb-direct-upload
branch
from
83087f5 to
14b1cba
Compare
lavoiesl
force-pushed
the
seb-assets-pipeline
branch
from
3608265 to
24fb7da
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1029
Adds the ability to enable direct uploads, which can help circumvent upload limits on the server.