Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace build_enumerator with enumerator_builder in README #1050

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Replace build_enumerator with enumerator_builder in README #1050

merged 1 commit into from
Jul 23, 2024

Conversation

yjukaku
Copy link
Contributor

@yjukaku yjukaku commented Jul 9, 2024

Fixes #1049

#enumerator_builder is the right method to test, while #build_enumerator is an internal method on a different class.

@yjukaku
Copy link
Contributor Author

yjukaku commented Jul 9, 2024

I have signed the CLA!

etiennebarrie
etiennebarrie approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@etiennebarrie etiennebarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebarrie etiennebarrie merged commit f2efd8b into Shopify:main Jul 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README mentions testing custom enumerators via #build_enumerator but should that be #enumerator_builder?
2 participants
@yjukaku @etiennebarrie