-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Generator to Properly Install Engine in Host Apps #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
install-generator-for-engine
branch
from
October 2, 2020 15:48
eca833f
to
bf6514e
Compare
lib/generators/maintenance_tasks/templates/maintenance_tasks.rb.tt
Outdated
Show resolved
Hide resolved
test/lib/generators/maintenance_tasks/install_generator_test.rb
Outdated
Show resolved
Hide resolved
etiennebarrie
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
We should also add that to the README so that people know to run that after adding the gem.
lib/generators/maintenance_tasks/templates/maintenance_tasks.rb.tt
Outdated
Show resolved
Hide resolved
test/lib/generators/maintenance_tasks/install_generator_test.rb
Outdated
Show resolved
Hide resolved
@volmer this is ready for a look when you have a chance 😄 |
volmer
approved these changes
Oct 5, 2020
adrianna-chang-shopify
force-pushed
the
install-generator-for-engine
branch
2 times, most recently
from
October 6, 2020 12:48
d941149
to
be5d91c
Compare
adrianna-chang-shopify
force-pushed
the
install-generator-for-engine
branch
from
October 6, 2020 12:50
be5d91c
to
80e6e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16
Background
rails g maintenance_tasks:install
in order to complete the setupSummary of Changes in this PR:
Implementing abstract_class in MaintenanceTasks::Task
ApplicationTask
from the list of tasks that are available to enqueue in the UIImplementing the install generator
ApplicationTask
classTo 🎩
http://localhost:3000/maintenance_tasks
To test the install generator:
cd test/dummy
rm db/schema.rb config/initializers/maintenance_tasks.rb app/jobs/maintenance/application_task.rb
rails db:drop
(so we can run the migrations)rails g maintenance_tasks:install
AFTER YOU'RE DONE
rails db:drop db:setup