Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move index creating to the create table block #239

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Move index creating to the create table block #239

merged 1 commit into from
Dec 11, 2020

Conversation

volmer
Copy link
Contributor

@volmer volmer commented Dec 11, 2020

The default migration adds the indices after creating the table. For Rails apps using LHM, that violates the migration vs LHM policies, so I moved the index calls inside the create_table call.

(@simonlevasseur)

@volmer volmer merged commit a11caf3 into main Dec 11, 2020
@volmer volmer deleted the index branch December 11, 2020 19:29
@casperisfine casperisfine temporarily deployed to rubygems January 6, 2021 19:23 Inactive
@adrianna-chang-shopify adrianna-chang-shopify mentioned this pull request Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianna-chang-shopify adrianna-chang-shopify adrianna-chang-shopify approved these changes

@simonlevasseur simonlevasseur simonlevasseur approved these changes

@etiennebarrie etiennebarrie etiennebarrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@volmer @etiennebarrie @simonlevasseur @adrianna-chang-shopify @casperisfine