Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated timestamps for previous runs on show page #338

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Fix duplicated timestamps for previous runs on show page #338

merged 1 commit into from
Feb 19, 2021

Conversation

adrianna-chang-shopify
Copy link
Contributor

Duplicated timestamps are showing up for previous runs on the show page, since: #288.

We need to bring back conditionally showing run.status in the _info partial based on the value of with_status, and then have _run render the _info partial without duplicating the heading.

Currently on main

Index

Screen Shot 2021-02-19 at 2 06 37 PM

Show

Screen Shot 2021-02-19 at 2 06 52 PM

With fix

Index

Screen Shot 2021-02-19 at 2 08 21 PM

Show

Screen Shot 2021-02-19 at 2 06 10 PM

@adrianna-chang-shopify adrianna-chang-shopify merged commit 67a1ee5 into main Feb 19, 2021
@adrianna-chang-shopify adrianna-chang-shopify deleted the fix-views branch February 19, 2021 21:03
@adrianna-chang-shopify adrianna-chang-shopify temporarily deployed to rubygems March 1, 2021 21:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianna-chang-shopify @etiennebarrie