Allow resuming errored task runs #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
This seems like a nice quality of life improvement to the gem! Would you mind rebasing so we re-run CI, @sj26 ?
Allows clicking "Resume" on an errored run to resume the run from the errored point, preserving progress. This is useful for transient errors, like those from infrastructure, which have not yet been anticipated.
sj26
force-pushed
the
resume-errored-run
branch
from
4d1b31b to
d4544ec
Compare
|
Done! Thanks @adrianna-chang-shopify 🙏 |
adrianna-chang-shopify
approved these changes
Jan 2, 2024
|
Thanks @adrianna-chang-shopify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows clicking "Resume" on an errored run to resume the run from the errored point, preserving progress. This is useful for transient errors, like those from infrastructure, which have not yet been anticipated.
I'm not sure this is quite right, but I wanted to throw up some code to discuss 🙏
Fixes #851.