Merge pull request #2843 from Shopify/fix-tsc-error

Try fix tsc error on assigning string
Shopify · Jan 8, 2025 · 73c7dd1 · 73c7dd1
2 parents cc31a44 + 7fc9a4e
commit 73c7dd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react-html/src/server/tests/stream.test.tsx b/packages/react-html/src/server/tests/stream.test.tsx
@@ -15,7 +15,7 @@ describe('stream', () => {
 
 function streamResponse(stream: NodeJS.ReadableStream) {
   return new Promise<string>((resolve) => {
-    let response: string;
+    let response = '';
 
     stream.on('data', (data) => (response += data));
     stream.on('end', () => resolve(response));

diff --git a/packages/react-server/src/render/tests/render.test.tsx b/packages/react-server/src/render/tests/render.test.tsx
@@ -248,7 +248,7 @@ describe('createRender', () => {
 
 function readStream(stream: NodeJS.ReadableStream) {
   return new Promise<string>((resolve) => {
-    let response: string;
+    let response = '';
 
     stream.on('data', (data) => (response += data));
     stream.on('end', () => resolve(response));