This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
[react-form] reset dynamic list #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvhama
commented
Apr 13, 2021
Comment on lines
-72
to
+76
| dispatch(resetAction({target})); | ||
| if (state.isDynamic) { | ||
| dispatch(resetListAction()); | ||
| } else { | ||
| dispatch(resetAction({target})); |
There was a problem hiding this comment.
Problem with this: it will reset the whole list for each item :/ Maybe we could find a better way to avoid performances caveats?
There was a problem hiding this comment.
I dont think we should do this because it means you will not be able to reset individual items if you are using a dynamic list. Also I feel like that would be taking away some functionality that might break flows for people already using DynamicList
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1830
Inspired by #1828
Type of change
It does a full reset of a dynamic list instead of resetting each existing field.
So items that have been removed will reappear and items that have been added will disappear.
react-formPatch: Bug (non-breaking change which fixes an issue)Checklist