Update and Map Deprecated Timezone #2842

ginabak · 2025-01-08T01:20:02Z

Description

(similar to shopify-internal)

📣 ❤️ co-authors with @trishrempel @christina-tran @jesstelford ❤️

Preps https://github.com/Shopify/web/issues/146409
Preps https://github.com/Shopify/web/issues/150625

There are some bugsnag errors for the error, errorMessage:"Invalid time zone specified: Europe/Kyiv", although browser versions are part of this 🙄 , we decided that the best fix would be to allow for deprecated timezones as some of the browser versions are recent like 131 for chrome, seen here on BugSnag

This PR:

allows for Europe/Kyiv for older browsers 😬 (basically it's now backwards compatible), a thought though ... I'm curious if the deprecated Europe/Kiev is no longer allowed (which probably won't happen for a while ... ) we'll have to delete this line 😄
maps the Europe/Kyiv timezone for react-i18n

shopify-shipitnext · 2025-01-08T01:20:05Z

🔎 View this PR in Shipit Next.

ℹ️ Expand to learn how to deploy and handle emergencies using Shipit Next

Overview

Shipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue.

To ship this PR, you can either:

Comment /shipit to enqueue this PR for merging.
Go to this PR in Shipit Next and click on the "Ship It" button in the top-right corner.

Comment Commands

/shipit: Enqueue this PR into the merge queue where it will eventually be merged and deployed.
/cancel: Eject this PR from the merge queue and rebuild PRs that were enqueued after this PR.
/shipit --jump-queue: Enqueue this PR at the top of the merge queue where it will be included in the next deploy. Use this for non-emergency situations.
- Emergency handling procedure for this command can be found here.
/shipit --emergency: Merge this PR directly into main and deploy to all environments once all require_for_emergency CI checks pass. Please be aware that changes deployed with this command will not be automatically rolled back.
- Emergency handling procedure for this command can be found here.

Commands exclusive to Deploy Before Merge

/cancel --emergency: Eject this PR from the merge and rollback any deployments containing this PR.

Documentation

ℹ️ You can read how the merge queue works in Vault here.
⚠️ Emergency handling documentation in the Vault describes how to handle emergencies, e.g. failed canaries, broken code in production, etc.

Questions or feedback?

Non-urgent questions can be submitted in our Discourse.
Feedback can be submitted in our frustrations Google form.
If you have feature requests, you may add them or vote for them in our GitHub repository.

ginabak · 2025-01-08T01:20:10Z

/snapit

ginabak · 2025-01-08T01:28:37Z

packages/react-i18n/src/i18n.ts

@@ -825,4 +833,8 @@ export class I18n {
  private defaultOnError(error: I18nError) {
    throw error;
  }
+
+  private normalizeTimezone(timeZone?: string) {
+    return timeZone ? mapDeprecatedTimezones(timeZone) : undefined;


We initially had a test added to this - but the tests were actually a false positive, testing date for date, the test for the mapping is actually seen in

quilt/packages/dates/src/tests/map-deprecated-timezones.test.ts

Line 4 in cc31a44

it('maps deprecated timezones', () => {

Co-authored-by: Trish Rempel <[email protected]> Co-authored-by: Christina Tran <[email protected]> Co-authored-by: Jess Telford <[email protected]>

ginabak · 2025-01-08T01:45:31Z

/snapit

github-actions · 2025-01-08T01:47:12Z

🫰✨ Thanks @ginabak! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/dates": "0.0.0-snapshot-20250108014630",
"@shopify/react-i18n": "0.0.0-snapshot-20250108014630",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108014630"

Co-authored-by: Trish Rempel <[email protected]> Co-authored-by: Christina Tran <[email protected]>

ginabak · 2025-01-08T21:13:56Z

/snapit

ginabak · 2025-01-08T21:15:30Z

packages/dates/src/utilities/formatDate.ts

+  return memoizedGetDateTimeFormat(locales, {
+    ...options,
+    timeZone: options.timeZone
+      ? mapDeprecatedTimezones(options.timeZone)


HIII @jesstelford ❤️ SOOOOOOOOOO when we implemented the change inside i18n and tested out the snapshots ... we weren't able to see the changes actually fix the issue 😬 .... so we're trying it out directly in formatDate as parts of web directly call formatDate from @shopify/dates we shipped https://github.com/Shopify/web/pull/152962/files that actually fixes it in web, but if we wanted to do our "due diligence" for other repo's, thought we might as well try this LOL 😄

Interesting! During your testing, did you notice any regressions with this change (trying some different mapped and non-mapped timezones)? If not, I agree we should ship this as a bug fix to ensure we've covered all our bases.

HIII JESS!!! do you mean for the i18n testing? Or this current one? SADLY Npm hasn't finished propogating lol, so I'm just waiting to test 😢

github-actions · 2025-01-08T21:15:37Z

🫰✨ Thanks @ginabak! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/dates": "0.0.0-snapshot-20250108211454",
"@shopify/react-i18n": "0.0.0-snapshot-20250108211454",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20250108211454"

ginabak · 2025-01-08T21:16:57Z

packages/dates/src/utilities/tests/formatDate.test.ts

+    };
+
+    formatDate(date, locale, options);
+    expect(mapDeprecatedTimezones).toHaveBeenCalledWith('Europe/Kyiv');


THIS TEST ISN'T GREAT ... but like at least we're testing that the function is actually being called, AND the fact that quilt/packages/dates/src/tests/map-deprecated-timezones.test.ts is testing that it's mapping / converting, feels safe to me - Ideally mocking out a real "bug" would be great here, but since we can't ... this is good enough imo 😄 ❤️

ginabak · 2025-01-09T21:10:26Z

WAS ABLE TO SUCCESSFULLY tophat in WEB that this actually fixes the deprecated timezone (the screenshot is the purchase order page, where we just manually added the .formatDate on the page, before the fix it was rendering the 500 ReferenceError and now it looks like:

ginabak force-pushed the i18n/date branch from 3ad0e57 to 76d5cc0 Compare January 8, 2025 01:23

ginabak commented Jan 8, 2025

View reviewed changes

ginabak marked this pull request as ready for review January 8, 2025 01:28

ginabak requested a review from a team as a code owner January 8, 2025 01:28

ginabak requested review from emiryy and ciuliano-shopify January 8, 2025 01:28

Update and map deprecated timezone

8588780

Co-authored-by: Trish Rempel <[email protected]> Co-authored-by: Christina Tran <[email protected]> Co-authored-by: Jess Telford <[email protected]>

ginabak force-pushed the i18n/date branch from 76d5cc0 to 8588780 Compare January 8, 2025 01:45

jesstelford approved these changes Jan 8, 2025

View reviewed changes

christina-tran assigned ginabak, trishrempel, jesstelford and christina-tran Jan 8, 2025

Map deprecated timezone in shopify/dates

15d1332

Co-authored-by: Trish Rempel <[email protected]> Co-authored-by: Christina Tran <[email protected]>

ginabak force-pushed the i18n/date branch from 6111c4f to 15d1332 Compare January 8, 2025 21:13

ginabak commented Jan 8, 2025

View reviewed changes

Update light-students-learn.md

6ed58ab

jesstelford approved these changes Jan 10, 2025

View reviewed changes

jesstelford merged commit d2c9fae into main Jan 10, 2025
5 checks passed

jesstelford deleted the i18n/date branch January 10, 2025 01:50

shopify-github-actions-access bot mentioned this pull request Jan 10, 2025

Version Packages #2845

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update and Map Deprecated Timezone #2842

Update and Map Deprecated Timezone #2842

ginabak commented Jan 8, 2025 •

edited

Loading

shopify-shipitnext bot commented Jan 8, 2025

Overview

Comment Commands

Commands exclusive to Deploy Before Merge

Documentation

Questions or feedback?

ginabak commented Jan 8, 2025

ginabak Jan 8, 2025 •

edited

Loading

ginabak commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

ginabak commented Jan 8, 2025

ginabak Jan 8, 2025

jesstelford Jan 8, 2025

ginabak Jan 8, 2025

github-actions bot commented Jan 8, 2025

ginabak Jan 8, 2025

ginabak commented Jan 9, 2025

Update and Map Deprecated Timezone #2842

Update and Map Deprecated Timezone #2842

Conversation

ginabak commented Jan 8, 2025 • edited Loading

Description

shopify-shipitnext bot commented Jan 8, 2025

Overview

Comment Commands

Commands exclusive to Deploy Before Merge

Documentation

Questions or feedback?

ginabak commented Jan 8, 2025

ginabak Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

ginabak commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

ginabak commented Jan 8, 2025

ginabak Jan 8, 2025

Choose a reason for hiding this comment

jesstelford Jan 8, 2025

Choose a reason for hiding this comment

ginabak Jan 8, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2025

ginabak Jan 8, 2025

Choose a reason for hiding this comment

ginabak commented Jan 9, 2025

ginabak commented Jan 8, 2025 •

edited

Loading

ginabak Jan 8, 2025 •

edited

Loading