Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unmount behavior #2619

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Improve unmount behavior #2619

merged 2 commits into from
Sep 10, 2024

Conversation

wcandillon
Copy link
Contributor

Before:

before.mp4

After:

after.mp4

To achieve this behaviour we needed to do two things:

  • Remove root deletion when unmounting (the root is deleted in the view destructor)
  • Don't update the drawing if the update is an unmount command

cc @colinta @beardwin

@wcandillon wcandillon merged commit d51beb3 into main Sep 10, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.3.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wcandillon