Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BindingConstantWithoutTypeAlias for type members with arguments #107

Merged
merged 1 commit into from
May 5, 2022

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented May 5, 2022

This shouldn't be an offense:

Sorbet/BindingConstantWithoutTypeAlias: It looks like you're trying to bind a type to a constant.
To do this, you must alias the type using T.type_alias.
--
  | A = type_member(:in) { { fixed: T.untyped } }
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@Morriar Morriar added the bugfix Fix a bug label May 5, 2022
@Morriar Morriar self-assigned this May 5, 2022
@Morriar Morriar requested a review from a team as a code owner May 5, 2022 00:06
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Morriar Morriar merged commit ee63710 into main May 5, 2022
@Morriar Morriar deleted the at-fix-type-members branch May 5, 2022 14:31
@shopify-shipit shopify-shipit bot temporarily deployed to production June 16, 2022 19:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants