-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Sorbet/RedundantExtendTSig
cop
#131
Conversation
2460e0a
to
d1e9eba
Compare
class RedundantExtendTSig < Base | ||
extend AutoCorrector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the way we generate docs doesn't support the Base
API, and requires the old Cop
API. I've updated it to the legacy approach to correction, and will open an issue to migrate.
d1e9eba
to
b2f9ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the cop 👍 . You have a CI failure on Ruby 3+
Switched to positional arguments. I'll squash commits when I'm back at my computer. What do you think of the offense message/docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small wording change to better emphasize which apps should use the cop.
(for anyone else wondering: this is patched by |
where it is useful to reduce noise. | ||
Enabled: false | ||
Safe: false | ||
VersionAdded: '<<next>>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually want to release the next version for a recent fix. Can we set this to 0.7.0
already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume Rubocop proper has tooling that does this automatically during the release process, but we haven't copied their tooling exactly (see #132). I think the expected workflow would be for the PR that bumps the version to do a find and replace of <<next>>
with whatever version it's bumping the gem to.
0931663
to
b646ef8
Compare
b646ef8
to
fd8f083
Compare
This cop is intended to be used in applications that have monkey patched
T::Sig
into all modules.It is disabled by default, as only application developers themselves can know if it applies to their app.