Add Ruby 3.2 to test matrix & use it in development #136
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test other versions in CI, so there's no reason not use the latest and greatest locally.
andyw8
approved these changes
Feb 3, 2023
andyw8
reviewed
Feb 3, 2023
| @@ -11,7 +11,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1' ] | |||
| ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2' ] | |||
There was a problem hiding this comment.
I wonder if we should drop 2.5 and 2.6.
There was a problem hiding this comment.
RuboCop itself tests against 2.6 upwards:
https://github.com/rubocop/rubocop/blob/master/.circleci/config.yml
There was a problem hiding this comment.
I was just creating a "we should publish 1.0" issue, in which I was going to recommend that be when we drop old Ruby versions, and switch to the new RuboCop APIs.
There was a problem hiding this comment.
The upcoming end-of-life of Ruby 2.7 might be a good time to drop everything older than Ruby 3, although that might be a little aggressive.
vinistock
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Ruby 3.2 to the test matrix & uses it in development. This doesn't change anything else. RuboCop remains configured to enforce 2.5 compatible syntax.