Refactor ForbidUntypedStructProps
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
Feb 21, 2023
| PATTERN | ||
|
|
||
| def on_class(node) | ||
| return unless subclass_of_t_struct?(node) | ||
|
|
||
| untyped_props(node).each do |untyped_prop| | ||
| add_offense(untyped_prop.child_nodes[1]) | ||
| untyped_props(node).each do |prop_type| |
There was a problem hiding this comment.
Do you mind adding a comment here or on top of def_node_search :untyped_props that says that the ${ ... } part in the node matcher is what captures the prop_type here.
I like the terseness of the usage, but it might be hard to understand what's going on for someone new to the project.
sambostock
commented
Feb 21, 2023
This makes the following changes: - Consolidates `T::Struct` and `T::ImmutableStruct` node matchers. - Use a capture in node search instead of indexing into child nodes.
sambostock
force-pushed
the
refactor-forbid-untyped-struct-props
branch
from
ce26473 to
758bf9e
Compare
paracycle
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes:
T::StructandT::ImmutableStructnode matchers.