Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest zsh-compatible rake syntax #166

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Suggest zsh-compatible rake syntax #166

merged 2 commits into from
Jul 19, 2023

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Jul 17, 2023

As requested by @Morriar in #165 (comment)

@dduugg dduugg requested a review from a team as a code owner July 17, 2023 04:02
@dduugg dduugg requested review from andyw8 and bitwise-aiden July 17, 2023 04:02
Morriar
Morriar reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the command in the README while at it?

rubocop-sorbet/README.md

Line 101 in 0a4c5ee

bundle exec rake new_cop[Sorbet/NewCopName]

@dduugg
Copy link
Contributor Author

dduugg commented Jul 19, 2023

Should we also update the command in the README while at it?

rubocop-sorbet/README.md

Line 101 in 0a4c5ee

bundle exec rake new_cop[Sorbet/NewCopName]

👍 PTAL

@Morriar
Copy link
Contributor

Morriar commented Jul 19, 2023

Thanks!

@Morriar Morriar merged commit 45d75b8 into Shopify:main Jul 19, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to production August 3, 2023 19:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriar Morriar Morriar approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 is a code owner automatically assigned from Shopify/sorbet

@bitwise-aiden bitwise-aiden Awaiting requested review from bitwise-aiden bitwise-aiden is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduugg @Morriar