Add ExactStrictness to Sorbet/ValidSigil cop
#167
Merged
+137
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for cases when a project wants to enforce a particular strictness for some part of its codebase, but nothing above or below that strictness for those files.
bitwise-aiden
approved these changes
Aug 2, 2023
KaanOzkan
approved these changes
Aug 2, 2023
| add_offense( | ||
| sigil, | ||
| location: sigil.pos, | ||
| message: "Sorbet sigil should be `#{exact_strictness}` got `#{strictness}`." |
There was a problem hiding this comment.
Is there value of mentioning the configuration in these offenses?
Suggested change
| message: "Sorbet sigil should be `#{exact_strictness}` got `#{strictness}`." | |
| message: "Sorbet sigil should be `#{exact_strictness}` per your configuration, got `#{strictness}`." |
There was a problem hiding this comment.
We hadn't been doing it so far, so I'd shy away from doing it as part of this PR. But it might be a good idea for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for cases when a project wants to enforce a particular strictness for some part of its codebase, but nothing above or below that strictness for those files.