Add final, bind, & implementation to SignatureBuildOrder

[sambostock]

This teaches SignatureBuildOrder to also enforce the ordering of final, bind, and implementation builder methods.

As per #186 (comment)

It also includes a refactor which

• drops the need for unparser, and
• teaches SignatureBuildOrder to handle sigs which include unknown builder methods, rather than ignore them

Before Merging

• Rebase after Document SignatureBuildOrder cop #186 is merged.

[sambostock]

We can probably skip specs for these, as the existing specs don't exhaustively cover the builder methods.

The documentation should be updated though.

[Morriar]

What if we took the order from an array in the configuration and we ship with a default (so we can use our preferred order and remove the old sig builders) but it enables people to use their own order and builders?

[paracycle]

What if we took the order from an array in the configuration and we ship with a default (so we can use our preferred order and remove the old sig builders) but it enables people to use their own order and builders?

Yeah, I like this idea...

[sambostock]

Oh, yeah, in retrospect that's definitely the way to go. 👍

I'll update when I get a minute.

[sambostock]

Okay, I've updated the cop to extract a config, and added the missing methods to that config.

[Morriar]

Very nice!

Do you mind adding a test that changes the order config please?

[sambostock]

I've added a test for the config change, and while doing that I realized I could improve the implementation to remove the need for unparser and handle unknown builder methods (by just ignoring them, rather than ignoring the entire sig).

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[paracycle]

Thank you, this looks great and I think it just fell through the cracks.

If you can rebase it, we can merge and release.