Set Sorbet/StrictSigil to Safe: false
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corsonknowles
force-pushed
the
strict_sigil_safety_declaration
branch
from
88bca35 to
301e6e0
Compare
corsonknowles
force-pushed
the
strict_sigil_safety_declaration
branch
4 times, most recently
from
42f8d46 to
b4de8e0
Compare
corsonknowles
force-pushed
the
strict_sigil_safety_declaration
branch
from
b4de8e0 to
92c7457
Compare
corsonknowles
changed the title
Sorbet/StrictSigil to SafeAutoCorrect: falseSorbet/StrictSigil to Safe: false
egiurleo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
Basically, because this cop can make existing files un-parsable by Sorbet, the correction should not be considered fully equivalent. Per the definition, we mark the autocorrect accordingly:
The end effect of this change is that this Cop will be run in
rubocop -Abut not byrubocop -aIt will also amend the notes
.rubocop_todo.ymlto look like:# This cop supports unsafe autocorrection (--autocorrect-all).As a large app maintainer, I recently examined our 1000 observed Rubocop rules, the 120 of them that had entries in
.rubocop_todo.yml, and the ones that were marked safe for autocorrection.This was one of about 4 examples that were marked safe for autocorrection, and yet did not return fully equivalent code.