Pluginfy RuboCop Performance #289
Open
+64
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Feb 26, 2025
paracycle
reviewed
Feb 26, 2025
There was a problem hiding this comment.
The changes look good to me, but I guess this will mean that 0.9 and above of this gem will only work with RuboCop 1.72.1 and above.
I wish there was a gradual pathway to doing this so that we didn't have to drop support for older versions of RuboCop. 1.72 is very new and not everyone may be ready to upgrade to that.
Can we not keep the janky inject code, and gate it on the RuboCop version to change behaviour?
This was referenced Mar 5, 2025
@paracycle done |
|
There are a few lint errors, looks like they can all be autocorrect with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RuboCop's Plugin feature:
rubocop/rubocop#13792