Always correct binding to multiline #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to auto-correct callback conditionals can produce incorrect code if the method used inside is private. E.g.:
Therefore, the only way of safely making these corrections is by always correcting to multi-line.
I also had to fix a documentation example which was breaking
rake
, so that I could re-generate the documentation.Note
We had discussed changing the purpose of this cop to add the
T.bind
into any arbitrary method that we could specify via configuration. However, the place we need to insert theT.bind
is different for certain types of methods.E.g.:
If you have any ideas of how we could make this configurable and generic, please let me know. But my suggestion would be to have a different cop for regular blocks and this one remains for callbacks only.